Use current_project_folder when running rubocop #70
Conversation
| # options, or an internal error. | ||
| # | ||
| @staticmethod | ||
| def is_err_unespected(returncode): |
|
Thank you very much for your contribution @dan-corneanu! The changes are looking pretty good in general - I have added one minor comment but nothing severe. Unfortunately I won't be able to test these changes in an appropriate way since Additionally due to a long term sickness this project's code lags a bit behind (... yes, this is an understatement). So it makes sense to search for a new maintainer for this plugin. @dan-corneanu Since you have opened this PR - would you possibly be interested to take over this repository as a maintainer? I am currently not sure what the correct process looks like for a situation like this (and especially all the required steps for a Sublime Text plugin in particular), so this might take a bit of time to get things sorted. (I assume it would just require a PR to https://github.com/wbond/package_control_channel as soon as a new maintainer is found) |
|
I have tested this PR locally, and it work like a charm, now the Could be merged from my point of view. Thanks @dan-corneanu. Also nice added debugs 🎉 |
I've added a few lines of code to log the out and err strings from the rubocop process if the process exit code is something else than 0 or 1. This should give some clues about why some commands have no result.
I have also set the
chdiroptions to thecurrent_project_folderwhen running rubocop. This makes sure that if you have a per project.rubocop.ymlit will be picked up.